Revert sigs.k8s.io/structured-merge-diff/v4 to v4.4.1#1220
Merged
afritzler merged 1 commit intoironcore-dev:mainfrom Jan 23, 2025
Merged
Conversation
afritzler
approved these changes
Jan 23, 2025
balpert89
pushed a commit
that referenced
this pull request
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR reverts the
sigs.k8s.io/structured-merge-diff/v4package from the current upgraded version back tov4.4.1.This change resolves an issue where versions above
v4.4.1cause intermittentINTERNAL_ERRORresponses during tests or server requests in theironcore-netproject.Error details
{ "ErrStatus": { "Status": "Failure", "Message": "the server is currently unable to handle the request (put networks.core.apinet.ironcore.dev <resource_id>)", "Reason": "ServiceUnavailable", "Details": { "Name": "<resource_id>", "Group": "core.apinet.ironcore.dev", "Kind": "networks", "Causes": [ { "Type": "UnexpectedServerResponse", "Message": "error trying to reach service: stream error: stream ID 1525; INTERNAL_ERROR; received from peer", "Field": "" } ] }, "Code": 503 } }Additional Notes:
The issue appears to stem from changes in the
sigs.k8s.io/structured-merge-diff/v4package introduced afterv4.4.1. Until the root cause is identified and fixed in a future release, the reversion is necessary to maintain stability.